[testing] Switch to logging with zap #3557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
commented
Nov 20, 2024
marun
commented
Nov 20, 2024
marun
commented
Nov 20, 2024
marun
commented
Nov 20, 2024
marun
commented
Nov 20, 2024
marun
commented
Nov 20, 2024
marun
commented
Nov 20, 2024
marun
commented
Nov 20, 2024
marun
commented
Nov 20, 2024
1 task
joshua-kim
reviewed
Nov 20, 2024
joshua-kim
approved these changes
Nov 20, 2024
tests/log.go
Outdated
Comment on lines
23
to
24
| // TODO(marun) Figure out why this is outputting e.g. `Level(-6)` instead of `INFO` | ||
| EncodeLevel: zapcore.LowercaseLevelEncoder, |
There was a problem hiding this comment.
We have modified how levels are encoded. We should be providing a custom leveler like in the rest of avalanchego:
func levelEncoder(l zapcore.Level, enc zapcore.PrimitiveArrayEncoder) {
enc.AppendString(Level(l).String())
}
func jsonLevelEncoder(l zapcore.Level, enc zapcore.PrimitiveArrayEncoder) {
enc.AppendString(Level(l).LowerString())
}See utils/logging/format.go#newTermEncoderConfig
There was a problem hiding this comment.
Any objection to exporting these functions so they can be reused?
There was a problem hiding this comment.
Nope - makes sense to me.
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: marun <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: marun <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: marun <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: marun <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: marun <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: marun <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: marun <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: marun <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: marun <[email protected]>
marun
force-pushed
the
testing-switch-to-zap
branch
from
cf8a4d4
to
292016a
Compare
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: marun <[email protected]>
StephenButtolph
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Previously testing used an incoherent mix of
TestContext.Outf,fmt.Printandfmt.Fprint. This PR switches everything to use the zap logger for consistency with the rest of avalanchego.How this works
How this was tested
CI
TODO
Level(-6)instead ofINFONeed to be documented in RELEASES.md?
N/A